🐛(tests) more stable tests #22
Open
+54
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bootstraping this project in the dev branch two additional directories are created: edx/src and edx/modules. To ease switching between a feature branch and the dev branch we choose to ignore the edx/modules directory.
When bootstraping this project in the dev branch two additional directories are created: edx/src and edx/modules. To ease switching between a feature branch and the dev branch we choose to make the linter ignore the edx directory.
2 tasks
To keep the circleci machine up to date.
SergioSim
force-pushed
the
more-stable-tests
branch
from
9a6430f to
0f034f4
Compare
3 tasks
This was referenced Nov 8, 2022
Comment on lines
+91
to
+94
| command: make bootstrap run-edx | ||
| - run: | ||
| name: Run e2e tests | ||
| command: make run-edx test | ||
| command: make test |
There was a problem hiding this comment.
I don't understand why you changed the commands
There was a problem hiding this comment.
The idea was to group together similar tasks.
Currently, in the bootstrap ci step, we start all services except the edX CMS and then in the test step, we start the CMS and run the tests.
Thus, I suggest starting all services in the bootstrap CI step and only running the tests in the test CI step.
WDYT?
There was a problem hiding this comment.
Indeed I think it's a good idea 👍
SergioSim
force-pushed
the
more-stable-tests
branch
4 times, most recently
from
93a9f6e to
d152577
Compare
The iframe in the js_input_response test needs some time to become interactive. Therefore we disable chromeWebSecurity to give cypress access to the cross-domain iframe to check whether the iframe is ready or not.
The drag_and_drop test relies on the problem beeing at it's initial state. However, edX preserves the state of the problem once it's submitted. Therefore we reset the drag_and_drop problem before answering it.
SergioSim
force-pushed
the
more-stable-tests
branch
from
d152577 to
152a6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
js_input_response_spec.jstest occasionally fails when it tries to access an iframe that has not yet been properly initialized.The
drag_and_drop_spec.jstest always fails on a second run because it preserves its previous state.We also updated the circle ci machine image to stay up to date and added entries to
.gitignoreand.eslintignoreto ease switching between the dev and feature branches.Proposal
js_input_response_spec.js- wait for the iframe to initializedrag_and_drop_spec.js- reset the problem before each attempt